Skip to content

Conversation

@SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Dec 10, 2022

Requires matrix-org/waterfall#70


This PR currently has none of the required changelog labels.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner marked this pull request as ready for review December 12, 2022 09:10
@SimonBrandner SimonBrandner requested review from a team as code owners December 12, 2022 09:10
@SimonBrandner SimonBrandner requested review from richvdh and t3chguy and removed request for a team December 12, 2022 09:10
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once the CI is happy

Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Copy link
Contributor Author

lgtm once the CI is happy

CI doesn't pass on the SFU branch either... Will try to resolve all the issues at once on that branch instead

@SimonBrandner SimonBrandner requested a review from dbkr December 12, 2022 12:15
@SimonBrandner SimonBrandner merged commit ca12d5a into matthew/sfu Dec 12, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/feat/event-shape branch December 12, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants